feat(Multichain): Multichain Safes with same address #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sidebar groups Safes with the same address and shows them first. - New designs for safe groups
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
987.26 KB (🟡 +26.16 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Fifteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
511 B (🟢 -24.37 KB) |
987.76 KB |
/address-book |
26.09 KB (🟡 +5 B) |
1013.34 KB |
/apps/open |
53.09 KB (-1 B) |
1.02 MB |
/balances |
29.42 KB (🟢 -1.52 KB) |
1016.67 KB |
/balances/nfts |
19.18 KB (-1 B) |
1006.44 KB |
/home |
57.22 KB (🟢 -923 B) |
1.02 MB |
/new-safe/advanced-create |
36.49 KB (🟡 +1.36 KB) |
1023.75 KB |
/new-safe/create |
35.75 KB (🟡 +1.36 KB) |
1023.01 KB |
/new-safe/load |
16.41 KB (🟡 +6 B) |
1003.67 KB |
/settings/modules |
9.82 KB (🟡 +38 B) |
997.08 KB |
/settings/notifications |
27.03 KB (-2 B) |
1014.28 KB |
/settings/setup |
35.98 KB (🟡 +5 B) |
1023.24 KB |
/transactions/tx |
21.07 KB (-2 B) |
1008.33 KB |
/welcome |
6.8 KB (🟢 -1 B) |
994.06 KB |
/welcome/accounts |
379 B (🟢 -1 B) |
987.63 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1541 tests passing in 205 suites. Report generated by 🧪jest coverage report action from c8f5406 |
- Implements replaying a Safe creation on another compatible network
ESLint Summary View Full Report
Report generated by eslint-plus-action |
schmanu
changed the title
ESLint Summary View Full Report
Report generated by eslint-plus-action |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
* feat: SetupToL2 during Safe creation * feat: use setupToL2 when relaying safe creation * Feat: add network selector to safe setup * feat: deploy CF safes on selected networks * feat: require at least on network to be selected * fix: creation overview network styles * Fix: only show wrong chain warning when relevant * fix: unit tests for ReviewStep and relay creation * fix: load safe cypress tests * remove unecessary check in safe creation * feat: simplify mnemonic safe name * fix: network multiselector chip styles * fix: update safe name unit test * refactor: change multiselector to uncontrolled component with RHF * fix: remove references to pay later option when it is not available * feat: exclude xksync from multichain and only offer chains of the same version * fix: dont allow older safes to be deployed as multichain group * only allow selecting a single network in the advanced safe creation flow * fix: check across chains for the next available saltNonce * fix: wrong chain warning on activation flow * allow CF deployment for m/n safes * feat: show success modal on multichain safe creation * fix: only allow networks with canonical 1.4.1 deployments to be multichain safes * fix: dismiss CF creation modal in cypress tests * feat: modify fee info text for multi chain safe creation * fix: remove unecessary promise.all and account for undefined numberOfOwners in setup hints * fix: remove unused code and use router.replace for network multi selector * refactor: move setup contract address to constants.ts * fix: check chains are compatible with first selected network and wrap multiselector functions in useCallbacl * fix: remove commented code --------- Co-authored-by: James Mealy <[email protected]>
…chain safe [SW-150] (#4151) * feat: add warning when adding or removing an owner to multichain safes * fix: change owner to signer in text and fix typos * feat: use current chain name in warning message
ESLint Summary View Full Report
Report generated by eslint-plus-action |
…-171] (#4163) * fix: Hide header network selector on non-safe routes * fix: Failing import export data e2e test * fix: Move MenuItem component back to be a function and fix e2e test * fix: Revert NetworkInput refactor * fix: Failing load_safe e2e test
ESLint Summary View Full Report
Report generated by eslint-plus-action |
…d mastercopy versions [SW-167] (#4161) Co-authored-by: schmanu <[email protected]>
…tiaccounts (#4125) - Redesigns how sub-items are displayed under multi-accounts. - Adds context menu for multi accounts offering renaming and adding a new network - Some UX fixes around the context menu
ESLint Summary View Full Report
Report generated by eslint-plus-action |
…4180) * fix: Network selector links and visual style * fix: Update dependency arrays
* fix: Show zksync network but disabled * fix: Show message if zksync safe is open * fix: Adjust tests for useReplayableNetworks
jmealy
force-pushed
the
epic/multichain-safes
branch
from
36c8bb6
to
916318f
Compare
* fix: Adjust chainId inbetween events when creating multichain safe * fix: Add missing events
…and changing threshold [SW-150] (#4198) * feat: show signer setup warning for swapping signer or changing threshold. * feat: move the change signer warning to the relavent block in the confirmation scree
…] [SW-211] (#4243) * feat: disable renaming multichain sub safes from the context menu * fix: when removing a CF safe, also remove it from the address book * feat: remove name input on replay safe modal * feat: do not show chain indicator when renaming a multichain safe * refactor: combine upsertAddressBookEntry and upsertMultichainAddressBookEntry * refactor: simplify upsertAddressBookEntries if-else block
# Conflicts: # src/features/counterfactual/ActivateAccountFlow.tsx
…/multichain-safes
* feat: fetch safe overviews using rtk query * fix: do not load safe overview for undeployed Safes
…4251) * Feat(Multichain): update text on safe creation review step * update create button text
…9] (#4262) * feat: use actual contract addresses from safe-deployments * pr comments, use typechain * remove unecessary undefined check for safeToL2SetupInterface
* fix: Adjust multichain design * fix: Adjust border color
…#4289) * fix: ignore safe overview requests for empty safe addresses * refactor: use asError instead of casting * test: add missing test case * fix: skip undeployed Safe overviews in network selector
* fix: Check all fallbackHandler deployments * fix: Add list of networks the twap fallback handler is deployed at and adjust check * fix: Add tests for twap fallback handler
…SW-240] (#4288) * feat: add checks for add network feature flag. * fix: remove condition for 141 to be enabled * feat: do not show add network option in context menu when feature is disabled * hide add network button on multichain groups * feat: hide disabled networks instead of disabling them in the networks selector and network input * rename feature flag variable for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCLAIMER
DO NOT MERGE THIS PR BEFORE THE USED CONTRACTS ARE FULLY AUDITED AND OFFICIALLY DEPLOYED
How is this Epic about?
This epic enables users to create Safes with the same address across L1 and L2 networks.
This involves
masterCopy(L1 or L2) during thesetupcall.How to test it
See the individual users stories acceptance criteria
Screenshots
tbd
Checklist